Skip to content

USHIFT-1372: Backing up the data is top priority#1993

Merged
openshift-merge-robot merged 1 commit into
openshift:mainfrom
pmtk:1372-backup-after-rollback
Jul 12, 2023
Merged

USHIFT-1372: Backing up the data is top priority#1993
openshift-merge-robot merged 1 commit into
openshift:mainfrom
pmtk:1372-backup-after-rollback

Conversation

@pmtk

@pmtk pmtk commented Jul 4, 2023

Copy link
Copy Markdown
Member
  • TestAgent.py for managing test agent config
  • Split ostree.resource
  • General cleanup of keywords related to upgrades
  • New test failed-upgrade.robot

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 4, 2023
@openshift-ci-robot

openshift-ci-robot commented Jul 4, 2023 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@pmtk: This pull request references USHIFT-1372 which is a valid jira issue.

Details

In response to this:

  • TestAgent.py for managing test agent config
  • Split ostree.resource
  • General cleanup of keywords related to upgrades
  • New test failed-upgrade.robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from copejon and jerpeter1 July 4, 2023 10:54
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2023
@pmtk pmtk force-pushed the 1372-backup-after-rollback branch from 6fa2ace to eca9933 Compare July 4, 2023 11:11
dhellmann
dhellmann reviewed Jul 5, 2023
View reviewed changes
Comment thread test/resources/ostree.resource Outdated
dhellmann
dhellmann reviewed Jul 6, 2023
View reviewed changes
Comment thread test/resources/ostree.resource Outdated
Comment thread test/suites-ostree/failed-upgrade.robot Outdated
@pmtk pmtk force-pushed the 1372-backup-after-rollback branch from eca9933 to 80d7292 Compare July 10, 2023 07:20
@openshift-ci

openshift-ci Bot commented Jul 10, 2023

Copy link
Copy Markdown
Contributor

@pmtk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-reduced-arm 80d7292 link false /test e2e-openshift-conformance-reduced-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dhellmann
dhellmann reviewed Jul 11, 2023
View reviewed changes

@dhellmann dhellmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2023
@openshift-ci

openshift-ci Bot commented Jul 11, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4ea958d into openshift:main Jul 12, 2023
@pmtk pmtk deleted the 1372-backup-after-rollback branch July 12, 2023 07:09
This was referenced May 28, 2026
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhellmann dhellmann dhellmann left review comments

@copejon copejon Awaiting requested review from copejon

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

Assignees

@dhellmann dhellmann

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pmtk @openshift-ci-robot @dhellmann @openshift-merge-robot